Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Qt6 and MSVC 2019 Support #16611

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Qt6 and MSVC 2019 Support #16611

wants to merge 10 commits into from

Conversation

dpaulat
Copy link

@dpaulat dpaulat commented Jun 6, 2021 •
edited
Loading

This pull request supports MSVC 2019 and Qt 6.1.0. Backward compatibility with Qt5 has been retained.

  • No visuals have been impacted
  • Tests have been updated for MSVC 2019. A few tests have been disabled, due to Windows platform support. Tests have been verified as passing using MSVC 2019 16.10 (14.29.30037) using the 64-bit compiler, with Qt 6.1.0.
  • No API changes have been made
  • Only Qt (and Windows) functionality should be impacted by this PR

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • tagged @mapbox/maps-android @mapbox/maps-ios @mapbox/core-sdk if this PR adds or updates a public API
  • tagged @mapbox/gl-js if this PR includes shader changes or needs a js port
  • apply needs changelog label if a changelog is needed (remove label when added)
  • Requires an update to boost headers before merging: Fix proto/generate.hpp for msvc2019 mapbox-gl-native-boost#2

@dpaulat dpaulat mentioned this pull request Jun 6, 2021
Open
@dpaulat
Copy link
Author

dpaulat commented Jun 6, 2021

Merging of this pull request should resolve the following issues:

@dpaulat dpaulat marked this pull request as ready for review June 6, 2021 15:43
@dpaulat dpaulat requested a review from a team as a code owner June 6, 2021 15:43
@ntadej
Copy link
Contributor

ntadej commented Jul 4, 2021

This repository is no longer under (open) development. It might be more useful if you port this MR to https://github.com/maplibre/maplibre-gl-native.

@dpaulat
Copy link
Author

dpaulat commented Jul 4, 2021

This repository is no longer under (open) development. It might be more useful if you port this MR to https://github.com/maplibre/maplibre-gl-native.

Great! I was concerned when I saw other pull requests getting ignored. Glad to see there's a fork with an active community. I'll revisit this in the next couple weeks, and reopen the pull request if maplibre is missing the support I need.

@dpaulat
Copy link
Author

dpaulat commented Jul 5, 2021

This repository is no longer under (open) development. It might be more useful if you port this MR to https://github.com/maplibre/maplibre-gl-native.

I have something in-work. It'll take me at least a few days to get a PR ready. There have been a few breaking changes on the master branch. Your PR helps, but I still need to fix some other errors and add at least a zlib dependency for mbtiles.

@ntadej
Copy link
Contributor

ntadej commented Jul 5, 2021

Thanks for looking into it!

We probably don't have to fix all at once. My initial goal is to have something build to setup the CI and then fix the remaining issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpaulat @ntadej